Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move query of contributors from the github api to the core collection hook from the facade hook #2291

Merged
merged 4 commits into from Apr 7, 2023
Merged

Move query of contributors from the github api to the core collection hook from the facade hook #2291

merged 4 commits into from Apr 7, 2023

Conversation

IsaacMilarky
Copy link
Contributor

@IsaacMilarky IsaacMilarky commented Apr 5, 2023 •
edited

Description
This pr is a version of #2285 with the changes requested from @ABrain7710

Signed commits

  • Yes, I signed my commits.

@IsaacMilarky
Implement requested changes for retrieve_dict_from_endpoint
19cf784 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
@IsaacMilarky
Implement requested changes for create_endpoint_from_repo_id
5fe6bda 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
@IsaacMilarky
Implement requested changes for grab_comitters
68e67db 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
@IsaacMilarky
merge with dev
cd86d91 
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
sgoggins
sgoggins reviewed Apr 7, 2023
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do end up with some unresolved contributors on commits sometimes. This seems kind of impossible if we are querying the commit hash for the gh_login. Does this fix this, or at least not make it worse?

@sgoggins sgoggins merged commit d33ab75 into dev Apr 7, 2023
1 check passed
@sgoggins sgoggins deleted the move-grab-committers branch February 20, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IsaacMilarky @sgoggins