Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure status of repo is updated when the cloning fails #2394

Merged
merged 1 commit into from May 3, 2023

Conversation

IsaacMilarky
Copy link
Contributor

@IsaacMilarky IsaacMilarky commented May 3, 2023

Description
Fix issue where repos were not getting marked as failed when cloning them via git fails.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
@sgoggins sgoggins merged commit b38f181 into dev May 3, 2023
1 check passed
@ABrain7710
Copy link
Contributor

@IsaacMilarky / @sgoggins I don't think this was necessary, because repo is set to Failed Clone right before the GitCloneError is raised. Line 167 of repofetch.py does it

@sgoggins
Copy link
Member

sgoggins commented May 3, 2023

@ABrain7710 : I know it wasn't always working. I don't know if this patch solves that or not.

@sgoggins sgoggins deleted the facade-clone-error-handle-fix branch February 20, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants