Handle GitHub API 204 response #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
IsaacMilarky
approved these changes
May 11, 2023
sgoggins
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://api.github.com/repos/{owner}/{repo}/contributors?state=all, which is used ingrab_commitersreturns a204 No Contentstatus and an empty string when there are not contributors. This was causing the response to be processed as a string, and a warning was logged because it was unable to be processed. Now if a204 No Contentstatus is returned by the Github API then all an empty list is returned with a status ofSuccessSigned commits