Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from graphql branch and debugging branch #2549

Merged
merged 24 commits into from Oct 18, 2023
Merged

Conversation

sgoggins
Copy link
Member

Description

  • GraphQL API
  • Minor bug fixes

ABrain7710 and others added 23 commits September 16, 2023 15:27
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Dev to GraphQL-API-Experiment
Signed-off-by: Sean Goggins <outdoors@acm.org>
Signed-off-by: Sean Goggins <outdoors@acm.org>
Signed-off-by: Sean Goggins <outdoors@acm.org>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Sean P. Goggins <gogginss@missouri.edu>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Updating Graphql API Experiment
Signed-off-by: Sean Goggins <s@goggins.com>
Updating data fixer with dev
Graphql api experiment into test for pr review fixes
Signed-off-by: Sean Goggins <s@goggins.com>
Signed-off-by: Sean Goggins <s@goggins.com>
Copy link
Member Author

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -184,7 +184,7 @@ def determine_worker_processes(ratio,maximum):
sleep_time += 6

#15% of estimate, Maximum value of 20
facade_num_processes = determine_worker_processes(.2, 20)
facade_num_processes = determine_worker_processes(.15, 20)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be 20% so that the sum of the percentages is 100%. 60% core + 20% secondary + 20% facade = 100%. Whereas 15% would cause the sum to 95%

Signed-off-by: Sean Goggins <s@goggins.com>
@sgoggins sgoggins merged commit 8093724 into dev Oct 18, 2023
1 of 2 checks passed
@sgoggins sgoggins deleted the data-fixer-reviews branch February 20, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants