Allow exception visibility in CLI #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ulincsys <ulincsys@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -7,6 +7,8 @@ | |||
| import click | |||
| import importlib | |||
| import traceback | |||
|
|
|||
| from pathlib import Path | |||
| # import augur.application | |||
|
|
|||
| CONTEXT_SETTINGS = dict(auto_envvar_prefix='AUGUR') | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1735: Consider using '{"auto_envvar_prefix": 'AUGUR'}' instead of a call to 'dict'. (use-dict-literal)
| @@ -24,11 +26,16 @@ def list_commands(self, ctx): | |||
| return rv | |||
|
|
|||
| def get_command(self, ctx, name): | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0237: Parameter 'cmd_name' has been renamed to 'name' in overriding 'AugurMultiCommand.get_command' method (arguments-renamed)
| @@ -24,11 +26,16 @@ def list_commands(self, ctx): | |||
| return rv | |||
|
|
|||
| def get_command(self, ctx, name): | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
IsaacMilarky
previously approved these changes
Mar 13, 2024
sgoggins
dismissed stale reviews from IsaacMilarky and themself
The base branch was changed.
sgoggins
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes the CLI pass-through all exceptions when they occur while loading a module.
Previously, import exceptions were silenced during import of a CLI command module. Although most exceptions would have been displayed, by catching
ModuleNotFoundError, any import errors in sub-modules would be silenced during Click imports.The fix is to check first if the module exists using a file check, and if it does not, return None to indicate as such.
Signed commits