Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Install Chmod Issue as Well as SQL Syntax #2737

Merged
merged 3 commits into from Mar 13, 2024
Merged

Fix Install Chmod Issue as Well as SQL Syntax #2737

merged 3 commits into from Mar 13, 2024

Conversation

IsaacMilarky
Copy link
Contributor

Description

  • Fix os module not being imported in install script for file permission purposes for .pgpass file
  • Fix stat module not being present when using stat.IWRITE and stat.IREAD
  • Fix SQL syntax in Nadia endpoint
  • Add error handling if no contributors were found in Nadia endpoint

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
@@ -1,4 +1,5 @@
# SPDX-License-Identifier: MIT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0114: Missing module docstring (missing-module-docstring)

@@ -1,4 +1,5 @@
# SPDX-License-Identifier: MIT
import os
from os import environ, chmod, path, getenv, stat
import logging
from sys import exit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0622: Redefining built-in 'exit' (redefined-builtin)

augur/application/cli/db.py Outdated Show resolved Hide resolved
augur/application/cli/db.py Outdated Show resolved Hide resolved
augur/application/cli/db.py Outdated Show resolved Hide resolved
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
@sgoggins sgoggins merged commit 2667f0d into dev Mar 13, 2024
8 checks passed
@IsaacMilarky IsaacMilarky deleted the dev-patch branch March 13, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants