Release v0.13.1 #924
Merged
Release v0.13.1 #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates release worker to insert new values when release_id is not already inserted and update when a row exist. Includes few tiny fixes Signed-off-by: Ivana Yovcheva <iyovcheva@vmware.com>
Update release worker
This change checks for and adds tags to the `releases` table when they are used instead of actual GitHub releases. It also adds metrics for tag_only releases Signed-off-by: Ivana Yovcheva <iyovcheva@vmware.com>
Add tag_only releases to the release worker
Signed-off-by: Carter Landis <c@carterlandis.com>
Signed-off-by: Carter Landis <c@carterlandis.com>
Update release worker
…ses to send SIGKILL after waiting 15 seconds and checking what is still running again." This reverts commit 7826039.
Signed-off-by: Carter Landis <c@carterlandis.com>
Signed-off-by: Carter Landis <c@carterlandis.com>
Fix Augur process control commands
Currently, on all branches, using `augur configure generate` (the augur lib command to create a config file) behaves in an undesirable way if installed using `make install`. The issue is that after running `augur configure generate`, if you used `make install` to install Augur, your config file is not written to root of your cloned source code directory. It is instead written to the `site-packages/augur/` folder that lives with your Python binary inside your virtualenv folder. The reason that it writes to this location is due to how I implemented the config generation script. The script uses a package-level variable called `ROOT_AUGUR_DIRECTORY` to determine the location of the root of the file currently that is currently running; when installed in non-editable mode (without using the `-e` flag, like in `make install`), `pip` will copy ONLY the files defined in your `MANIFEST.in` from your cloned source code directory (if that's what you're installing) into that `site-packages` folder; **these are the files that are "running" when using augur installed in non-editable mode** - that is, without `-e`. However, when installing the package in editable mode with `-e` (like `pip install -e .` in `make install-dev`), the files are **not** copied into that folder. Instead, some stuff happens behind the scenes, and `pip` links the contents of your local cloned directory to the `site-packages` folder; this is what allows you to make changes, save, and then run the commands again. That means when we use `install-dev`, **these are the files that are running when we execute augur commands. This is why the augur.config.json file is always installed to your cloned source code directory; that's the "root" of the currently running Augur binary. There's a very important caveat to using `make install`, however; _it has no way of knowing where you installed the binary from_. This means it has _no way of installing the config file to your cloned source code directory_. In fact, it's not even guranteed that the source is on your machine; all the other packages you install with `pip` like `pandas` only have the files in their `MANIFEST.in` copied as well. If we want the config file to only ever be in one location, then this is problem; it can't be in the source code directory like it has been. We need to pick a standard location on the file system to store the config file outside the cloned source code tree. To this end, this patch changes the default config file location `$HOME/.augur/augur.config.json`. However, if it detects a config file in the root Augur directory, then it will use that instead. Signed-off-by: Carter Landis <c@carterlandis.com>
Signed-off-by: Carter Landis <c@carterlandis.com>
Update default config file location
This patch exposes the logs for the dependency installation process, including all errors. It also moves all logs from logs/install to just logs/. Signed-off-by: Carter Landis <c@carterlandis.com>
Signed-off-by: Carter Landis <c@carterlandis.com>
Signed-off-by: Carter Landis <c@carterlandis.com>
Signed-off-by: Dawn M. Foster <fosterd@vmware.com>
Installation usability issues
ccarterlandis
added
feature-request
Signed-off-by: Carter Landis <c@carterlandis.com>
sgoggins
previously approved these changes
Sep 23, 2020
Signed-off-by: Carter Landis <c@carterlandis.com>
Add ability to create repo groupgs from GH orgs on the CLI
fixed a few links and avoided using the word 'here' as a link
|
@sgoggins & @gabe-heim this PR is ready for review |
sgoggins
approved these changes
Sep 29, 2020
|
@ccarterlandis and @gabe-heim : Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v0.13.1
Changelog
add-github-orgimplementationaugur util killusageaugur util stopaugur util killcli_kill_processes and kill_processes to send SIGKILL after waiting 15 seconds"tag_onlyreleases to the release worker