Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about @harshalmittal4 #112

Merged
merged 5 commits into from
Apr 4, 2019
Merged

Conversation

harshalmittal4
Copy link
Contributor

@harshalmittal4 harshalmittal4 commented Apr 2, 2019

Hello, I am interested in working upon the idea #2 Implementing CHAOSS metrics with Perceval
.

  1. Added the link to the microtask repository, would update it further.
  2. Would add the link to proposal once it is ready.

Thanks.
Hoping to work with you further and contributing always!

@vchrombie
Copy link
Member

@harshalmittal4
I think you forgot to sign-off the commits. You can have a look here https://github.com/chaoss/governance/blob/master/CONTRIBUTING.md#code-or-document-change-contributions-pull-request.

Signed-off-by: Harshal Mittal <harshalmittal4@gmail.com>
@harshalmittal4
Copy link
Contributor Author

Very thanks @vchrombie for your concern regarding this.

@harshalmittal4
Copy link
Contributor Author

harshalmittal4 commented Apr 4, 2019

Hey @valeriocos, @aswanipranjal, @jgbarah
It would be very helpful if you can review the microtasks and suggest the improvements or changes. Please may you have a look 😊
I would be adding the link to the proposal soon, thanks!

@valeriocos
Copy link
Member

please @harshalmittal4 could you resolve the conflicts? thanks!

@harshalmittal4
Copy link
Contributor Author

Done.

@valeriocos
Copy link
Member

Great thank you for the quick reaction @harshalmittal4 .
I see that you didn't provide the link of the proposal. What do you think to link a google doc (even if empty) and work on it later? This would avoid you to make another PR to include the link to the proposal.

Any suggestions @jgbarah and @aswanipranjal ?

@valeriocos
Copy link
Member

please squash the commits in one @harshalmittal4 and we are done :) thanks!

@harshalmittal4
Copy link
Contributor Author

harshalmittal4 commented Apr 4, 2019

Sorry @valeriocos, can't squash them since I pulled from upstream (this repo) to my local in between accidentally 😐, and git rebase is showing previous commits from this repo now.
I will definitely take care from next time!

Meanwhile, I'm working on the proposal and may you please review the microtasks if possible to see for any changes. Thanks!

@valeriocos
Copy link
Member

no worries @harshalmittal4 . @jgbarah I guess the pr can be merged, thanks!

Copy link
Contributor

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I still think this could be squashed (you can always pull from the branch in github, squash, and force push), but still, since the result is ok, let's go for it.

@jgbarah jgbarah merged commit 9752f30 into chaoss:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants