Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsoc 2019 info #128

Merged
merged 3 commits into from
Apr 9, 2019
Merged

gsoc 2019 info #128

merged 3 commits into from
Apr 9, 2019

Conversation

Sonub396
Copy link
Contributor

@Sonub396 Sonub396 commented Apr 9, 2019

add my info

@Sonub396
Copy link
Contributor Author

Sonub396 commented Apr 9, 2019

Hey,
I tried to create a pull request with the commands as you mentioned, but still it says Dco sign-off required

Sonub396 and others added 3 commits April 9, 2019 19:11
Signed-off-by: sonu.b <sonu.b@darwinbox.io>
Signed-off-by: Sonu Badugu <sonub396@gmail.com>
Signed-off-by: sonu.b <sonu.b@darwinbox.io>
Signed-off-by: sonu.b <sonu.b@darwinbox.io>
@GeorgLink
Copy link
Member

The content of the pull request looks good. Now you just need to get the DCO sign-off right 😉

Maybe start fresh with a new fork from the repository and work through the DCO sign-off. Here is a link to details on why the DCO check failed: https://github.com/chaoss/governance/pull/128/checks?check_run_id=97034610

@Sonub396
Copy link
Contributor Author

Sonub396 commented Apr 9, 2019

Hey,
Can you just check once if the sign-off is correct , because i got green ticks, just to ensure.
Thank you

@GeorgLink
Copy link
Member

Looks like you fixed it while I was typing my message 👍

Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your interest in CHAOSS

@GeorgLink GeorgLink merged commit 51ab070 into chaoss:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants