-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update release handbook #201
Conversation
Signed-off-by: Kevin Lumbard <kmlumbard@gmail.com>
This metric is part of the continuous release process and the information displayed on the website may still be edited prior to the regular release. - Matt |
continuous release list in release notes |
no labels on metric release page |
This metric is part of the continuous release process and has passed the 30 day comment period. This metric could, possibly, be edited prior to the regular release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @klumb
I have a few rearrangements and suggestions
Disclaimer shared with the Common WG: This metric is part of the continuous release process, has been through the 30-day review period, and the information displayed on the website may still be edited prior to the regular release |
@klumb where are we on this PR? I am referencing the community handbook in the CHAOSS weekly and it would be great to get the update merged. |
Co-Authored-By: Georg J.P. Link <linkgeorg@gmail.com>
Co-Authored-By: Georg J.P. Link <linkgeorg@gmail.com>
@GeorgLink I accepted your review changes. I would be comfortable merging this. |
However for some reason it DCO is failing now. |
That's unfortunate :(
|
Hi @klumb I think that the sign-off is missing in the last two commits. Try adding your sign-off.
You need to edit the existing commit message. Just try adding this to the last commit and check if it is working. You can do this by
This should open an editor for editing the commit message. Add your sign-off and force push.
I hope it helps. |
Hi @klumb I checked the error log of DCO. You can also do the same by clicking the I was correct, the sign-off was missing in the last two commits which led to the failure.
I hope this helps. Please let me know if you have any questions or trouble. |
Would anyone mind if I set the DCO to pass? I am sure it is from Georg's commits. |
no, I don't mind. We can squash merge and then it will not show up in the git log |
Signed-off-by: Kevin Lumbard kmlumbard@gmail.com
Added detail to the release process. Not completely sure on all of this so I welcome discussion.