Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release handbook #201

Merged
merged 3 commits into from
Apr 21, 2020
Merged

update release handbook #201

merged 3 commits into from
Apr 21, 2020

Conversation

klumb
Copy link
Member

@klumb klumb commented Apr 13, 2020

Signed-off-by: Kevin Lumbard kmlumbard@gmail.com

Added detail to the release process. Not completely sure on all of this so I welcome discussion.

Signed-off-by: Kevin Lumbard <kmlumbard@gmail.com>
@klumb
Copy link
Member Author

klumb commented Apr 14, 2020

This metric is part of the continuous release process and the information displayed on the website may still be edited prior to the regular release. - Matt

@klumb
Copy link
Member Author

klumb commented Apr 14, 2020

continuous release list in release notes

@klumb
Copy link
Member Author

klumb commented Apr 14, 2020

no labels on metric release page

@klumb
Copy link
Member Author

klumb commented Apr 14, 2020

This metric is part of the continuous release process and has passed the 30 day comment period. This metric could, possibly, be edited prior to the regular release.


Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @klumb

I have a few rearrangements and suggestions

community-handbook/metrics-release.md Outdated Show resolved Hide resolved
community-handbook/metrics-release.md Show resolved Hide resolved
community-handbook/metrics-release.md Outdated Show resolved Hide resolved
community-handbook/metrics-release.md Show resolved Hide resolved
@GeorgLink
Copy link
Member

Disclaimer shared with the Common WG: This metric is part of the continuous release process, has been through the 30-day review period, and the information displayed on the website may still be edited prior to the regular release

@GeorgLink
Copy link
Member

@klumb where are we on this PR? I am referencing the community handbook in the CHAOSS weekly and it would be great to get the update merged.

klumb and others added 2 commits April 19, 2020 11:06
Co-Authored-By: Georg J.P. Link <linkgeorg@gmail.com>
Co-Authored-By: Georg J.P. Link <linkgeorg@gmail.com>
@klumb
Copy link
Member Author

klumb commented Apr 19, 2020

@GeorgLink I accepted your review changes. I would be comfortable merging this.

@klumb
Copy link
Member Author

klumb commented Apr 19, 2020

However for some reason it DCO is failing now.

@GeorgLink
Copy link
Member

GeorgLink commented Apr 19, 2020 via email

@vchrombie
Copy link
Member

Hi @klumb
I am really not sure about this problem, but I think I have a workaround for this.
Maybe you can try on one commit and see if this thing works.
You can revert back the change if it doesn't.

I think that the sign-off is missing in the last two commits. Try adding your sign-off.

Co-Authored-By: Georg J.P. Link <linkgeorg@gmail.com>
Signed-off-by: Kevin Lumbard <kmlumbard@gmail.com>

You need to edit the existing commit message. Just try adding this to the last commit and check if it is working. You can do this by

$ git commit --ammend

This should open an editor for editing the commit message. Add your sign-off and force push.

$ git push -f origin branch_name

I hope it helps.

@vchrombie
Copy link
Member

Hi @klumb

I checked the error log of DCO. You can also do the same by clicking the Details beside the DCO check in this PR.

I was correct, the sign-off was missing in the last two commits which led to the failure.
I have found another workaround from the DCO help.

git rebase HEAD~3 --signoff
git push --force-with-lease origin master

I hope this helps. Please let me know if you have any questions or trouble.

@klumb
Copy link
Member Author

klumb commented Apr 19, 2020

Would anyone mind if I set the DCO to pass? I am sure it is from Georg's commits.

@GeorgLink
Copy link
Member

no, I don't mind. We can squash merge and then it will not show up in the git log

@klumb klumb merged commit 3ba9559 into chaoss:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants