Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding my proposal link #211

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Adding my proposal link #211

merged 2 commits into from
Jun 23, 2020

Conversation

tharun143
Copy link
Contributor

Signed-off-by: tharun143 tharunravuri2000@gmail.com

Signed-off-by: tharun143 <tharunravuri2000@gmail.com>
@vchrombie
Copy link
Member

Hi @tharun143
Thanks for the PR.

GSoD-interest.md Outdated
| Georg Link | linkgeorg@gmail.com | This is an example entry | Proposal Link |
| Tharun Ravuri | tharunravuri2000@gmail.com | Building Documentation for D&I Badging project | [Proposal Link](https://docs.google.com/document/d/1aEFSaIYKscs0Y8t3-9Zqu3-xSGaujatNCIZH3xKa9Ho/edit?usp=sharing) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to revert this change and add a new column under Georg Link entry. If possible add a new empty line under your entry.

Copy link
Member

@vchrombie vchrombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some changes, please have a look at it.
Let me know if you need any help.

You can simply change the file, add to the same commit and force push the branch.
In case you need some help

<change the file>

$ git add path_to_file
$ git commit --amend --no-edit
$ git push -f origin branch_name

Signed-off-by: tharun143 <tharunravuri2000@gmail.com>
@tharun143
Copy link
Contributor Author

@vchrombie I just added another commit to the same PR. Just making it simple

@tharun143
Copy link
Contributor Author

@GeorgLink @germonprez @SMotaal Is that okay if I propose my proposal in mailing list for review or feedback?

@vchrombie
Copy link
Member

Hi @tharun143, as you were around the discussion about the proposal, I would like to point this to you.

We worked on making a template for the proposal, GSoD proposal template for CHAOSS.
It would be really great if you can use it and update your existing proposal doc with the missing sections (if any).
Thanks.

@tharun143
Copy link
Contributor Author

@vchrombie Sure. The template looks awesome and standard. 😃

Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tharun143

@GeorgLink GeorgLink merged commit 8df3bff into chaoss:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants