-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add my GSoD proposal #219
Add my GSoD proposal #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiaoya-Esther
Can you please fix the DCO sign-off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the DCO sign-off
Hi @xiaoya-Esther This will fix the sign-off on the last commit.
This will push the changes (here, it is only the sign-off).
Let us know if you need any help. 😄 |
Hi @vchrombie thanks for your guide, I created this PR on Github, and signed the DCO using the extension scottrigby/dco-gh-ui, the check looks like this:
Should I change the name "Xiaoya Xia" into "Esther"? And since this was first initiated on GitHub, I should clone the branch |
Signed-off-by: Xiaoya Xia <xiaoyaxiaesther@gmail.com> Signed-off-by: xiaoya <2031361857@qq.com>
I think I get the workflow now:) Thanks! |
yes, exactly. 🙂
It looks perfect. Good work on the sign-off @xiaoya-Esther. 👍 |
Hi @xiaoya-Esther Let me know if you need any help. 🙂 |
Thanks @xiaoya-Esther |
Sorry, @vchrombie I just saw this message, thanks for the merge! |
Signed-off-by: Xiaoya Xia xiaoyaxiaesther@gmail.com