added focus-areas template #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ritik-malik <ritik18406@iiitd.ac.in>
GeorgLink
reviewed
Jun 21, 2021
templates/focus-areas.md
Outdated
|
|
||
| The following template describes the structure of READMEs for focus-areas in each WG repositories: | ||
|
|
||
| --- |
There was a problem hiding this comment.
Instead of lines, use
```
That will make the template look more like a template and can be copied more easily.
Signed-off-by: ritik-malik <ritik18406@iiitd.ac.in>
|
Thanks for making the change. It looks great. One more suggestion: change the headings "Part 1" and "Part 2" to something more descriptive. |
|
hmm how about we use their entire name as written in line 4 and 5 -
and
|
|
Good idea |
Signed-off-by: ritik-malik <ritik18406@iiitd.ac.in>
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As discussed in #276, I added the templates for focus-areas READMEs,
Would be happy to do the suggested changes.
Signed-off-by: ritik-malik ritik18406@iiitd.ac.in