-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed the MicroTasks #323
Conversation
Hi @ayush-8 AFAIK, GitHub assigns you an alt email if you didn't add your email to GitHub or you choose to keep your email private. In your case, it is The DCO bot checks if this commit email and the email provided in your sign-off are the same. The DCO sign-off check fails if there is any discrepancy in your name/email. Here is your case,
signoff
This discrepancy caused the DCO check to fail. What to do right now? Make sure you add your email to GitHub and make it your public email. If you choose to keep it private, use your alt email in your sign-off. In both cases, you need to amend the commit/commit message accordingly. Let us know if you need any help. |
Hii @vchrombie |
Now that you already committed it, this doesn't solve the problem. So, you amend the commit, update the email and force push the commits to your fork. |
Hi @ayush-8, please let us know if you need help. |
Hi @ayush-8, I would suggest you to clone the repo and fix the sign-off manually. GitHub interface doesn't allow to edit previous commits.
|
Still the same. |
I've tried using that email id showing in the details section of dco error, still no positive response. Should I close this pull request and re-initiate a new one? |
I see you are adding a new commit, but the reason why the check fails is the because of the first commit. It already has a faulty signature, so as I told earlier, you need to amend the 3 commits into one and fix the signature. I know it might be frustrating but I would highly suggest you to fix this in this PR. I'm saying this because you learn git by making mistakes and you are in the right direction. :) |
Signed-off-by: Ayush Kaushik <ayu08kau@gmail.com>
I have updated the PR. |
Signed-off-by: Ayush ayu08kau@gmail.com