Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed the MicroTasks #323

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Completed the MicroTasks #323

merged 1 commit into from
Apr 8, 2022

Conversation

ayush-8
Copy link
Contributor

@ayush-8 ayush-8 commented Apr 2, 2022

Signed-off-by: Ayush ayu08kau@gmail.com

@ayush-8 ayush-8 changed the title Completed the MicroTask0 and Microtask 2. Completed the MicroTasks Apr 2, 2022
@vchrombie
Copy link
Member

Hi @ayush-8

AFAIK, GitHub assigns you an alt email if you didn't add your email to GitHub or you choose to keep your email private. In your case, it is 55775311+ayush-8@users.noreply.github.com, reference. So, when you are committing using GitHub, this alt email will be used for your commit, reference.

The DCO bot checks if this commit email and the email provided in your sign-off are the same. The DCO sign-off check fails if there is any discrepancy in your name/email.

Here is your case,
commit

From: Ayush <55775311+ayush-8@users.noreply.github.com>

signoff

Signed-off-by: Ayush <ayu08kau@gmail.com>

This discrepancy caused the DCO check to fail.

What to do right now? Make sure you add your email to GitHub and make it your public email. If you choose to keep it private, use your alt email in your sign-off. In both cases, you need to amend the commit/commit message accordingly.

Let us know if you need any help.

@ayush-8
Copy link
Contributor Author

ayush-8 commented Apr 3, 2022

Hii @vchrombie
Thank you - I just updated my email's privacy.

@vchrombie
Copy link
Member

Thank you - I just updated my email's privacy.

Now that you already committed it, this doesn't solve the problem. So, you amend the commit, update the email and force push the commits to your fork.

@vchrombie
Copy link
Member

Hi @ayush-8, please let us know if you need help.

@vchrombie
Copy link
Member

vchrombie commented Apr 4, 2022

Hi @ayush-8, I would suggest you to clone the repo and fix the sign-off manually. GitHub interface doesn't allow to edit previous commits.

If you forget to add the sign-off you can also amend a previous commit with the sign-off. For this, you need to clone the repository on your local machine and run git commit --amend -s. Because you have pushed your changes to GitHub already you'll need to force push your branch after this with git push -f.

@ayush-8
Copy link
Contributor Author

ayush-8 commented Apr 4, 2022

Still the same.

@ayush-8
Copy link
Contributor Author

ayush-8 commented Apr 4, 2022

I've tried using that email id showing in the details section of dco error, still no positive response. Should I close this pull request and re-initiate a new one?

@vchrombie
Copy link
Member

I've tried using that email id showing in the details section of dco error, still no positive response. Should I close this pull request and re-initiate a new one?

I see you are adding a new commit, but the reason why the check fails is the because of the first commit. It already has a faulty signature, so as I told earlier, you need to amend the 3 commits into one and fix the signature.

I know it might be frustrating but I would highly suggest you to fix this in this PR. I'm saying this because you learn git by making mistakes and you are in the right direction. :)

Signed-off-by: Ayush Kaushik <ayu08kau@gmail.com>
@ayush-8
Copy link
Contributor Author

ayush-8 commented Apr 4, 2022

I have updated the PR.
Thank you @vchrombie

@vchrombie vchrombie mentioned this pull request Apr 8, 2022
@germonprez germonprez merged commit 0fff862 into chaoss:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants