Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea for GSoC: Implementing CHAOSS metrics with Perceval #72

Merged
merged 3 commits into from
Jan 31, 2019

Conversation

jgbarah
Copy link
Contributor

@jgbarah jgbarah commented Jan 23, 2019

This is a proposal for GSoC'2019.

Copy link
Collaborator

@germonprez germonprez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jgbarah - looks good to me. @GeorgLink ?

Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. I am excited about implementing GMD metrics. I request two minor changes.

GSoC-Ideas.md Outdated

\[Below, template for proposing ideas. Pull request with your idea. \]

### Idea #x:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the duplicate idea template (lines 43-60)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. Thanks for noticing.

GSoC-Ideas.md Outdated
and will explore the peculiarities of the metric and its implementation for that data source.

* Document the notebooks as much as possible, so that any person trying to implement the metric
can understand not only how to implement it, but also the details that should have into account.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 25: This sentence I don't understand; it seems incomplete: "but also the details that should have into account."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Is it more clear now?

Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add link to micro-tasks

Hopefully also addressing reviwer comments, including
a link to the microtasks and issue for discussion.
Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jgbarah for putting this together and posting the micro-tasks.

@GeorgLink GeorgLink merged commit 93c2f5f into master Jan 31, 2019
@GeorgLink GeorgLink deleted the jgbarah-patch-2 branch March 20, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants