-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea for GSoC: Implementing CHAOSS metrics with Perceval #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jgbarah - looks good to me. @GeorgLink ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together. I am excited about implementing GMD metrics. I request two minor changes.
GSoC-Ideas.md
Outdated
|
||
\[Below, template for proposing ideas. Pull request with your idea. \] | ||
|
||
### Idea #x: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the duplicate idea template (lines 43-60)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did. Thanks for noticing.
GSoC-Ideas.md
Outdated
and will explore the peculiarities of the metric and its implementation for that data source. | ||
|
||
* Document the notebooks as much as possible, so that any person trying to implement the metric | ||
can understand not only how to implement it, but also the details that should have into account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 25: This sentence I don't understand; it seems incomplete: "but also the details that should have into account."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Is it more clear now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add link to micro-tasks
6100253
to
2881064
Compare
Hopefully also addressing reviwer comments, including a link to the microtasks and issue for discussion.
2881064
to
c7817ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jgbarah for putting this together and posting the micro-tasks.
This is a proposal for GSoC'2019.