Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augur Submission One #75

Merged
merged 7 commits into from
Feb 4, 2019
Merged

Augur Submission One #75

merged 7 commits into from
Feb 4, 2019

Conversation

sgoggins
Copy link
Member

Augur GSoC Submission.

Copy link
Collaborator

@germonprez germonprez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar things but good to me. @GeorgLink ?

GSoC-Ideas.md Outdated Show resolved Hide resolved
GSoC-Ideas.md Outdated Show resolved Hide resolved
Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together.

The description is rich with details that make sense to us but may be difficult to understand for someone who has never heard of CHAOSS. Describing the full scope of Augur and what we learned so far makes this project seem very large and as a potential GSoC student, I am not sure how I could possibly contribute within the short time of the program.

My suggestion is to reduce the description and more narrowly describe one improvement that a GSoC student can make.

@germonprez
Copy link
Collaborator

@sgoggins can you address @GeorgLink comments? This is due really soon.

I took the contextualization off the top as requested.
@sgoggins
Copy link
Member Author

sgoggins commented Feb 4, 2019

I addressed @GeorgLink 's feedback. I think this is ready to merge.

Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sgoggins. I resolved the merge conflict.

Two minor things remain for you before we merge:

  • One comment (two lists of aims in lines 94-101) and
  • one change request (adding link to micro-tasks). [update: I fixed this]

GSoC-Ideas.md Outdated Show resolved Hide resolved
GSoC-Ideas.md Outdated Show resolved Hide resolved
@sgoggins
Copy link
Member Author

sgoggins commented Feb 4, 2019

I think its now ready to merge @GeorgLink

Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sgoggins

@GeorgLink GeorgLink merged commit abd8f47 into chaoss:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants