Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #97

Merged
merged 4 commits into from Apr 3, 2019
Merged

Update README.md #97

merged 4 commits into from Apr 3, 2019

Conversation

GeorgLink
Copy link
Member

this is a duplicate of #91 to see if the DCO bot is active

@GeorgLink
Update README.md
c6da566 
Signed-off-by: Georg J.P. Link <linkgeorg@gmail.com>
@GeorgLink GeorgLink mentioned this pull request Mar 19, 2019
Closed
@GeorgLink
Copy link
Member Author

As per #91, I continue to assume lazy consensus for merging by end of today.

geekygirldawn
geekygirldawn reviewed Mar 20, 2019
View reviewed changes
Copy link
Member

@geekygirldawn geekygirldawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a link to the contributing.md file?

@GeorgLink GeorgLink mentioned this pull request Mar 20, 2019
Closed
@GeorgLink
add CONTRIBUTING.md to README
dbe7ecb 
Signed-off-by: Georg J.P. Link <linkgeorg@gmail.com>
@GeorgLink
Copy link
Member Author

We should also add maintainers. I have done this in the past. Anyone else interested?

@GeorgLink
add Maintainer info to README
323d6fe 
Signed-off-by: Georg J.P. Link <linkgeorg@gmail.com>
@GeorgLink
change order of how to contribute information
b99eab8 
Signed-off-by: Georg J.P. Link <linkgeorg@gmail.com>
germonprez
germonprez approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@germonprez germonprez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@GeorgLink GeorgLink merged commit 4aeeb32 into master Apr 3, 2019
@ElizabethN ElizabethN deleted the GeorgLink-patch-2 branch February 3, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekygirldawn geekygirldawn geekygirldawn left review comments

@germonprez germonprez germonprez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GeorgLink @germonprez @geekygirldawn