[enriched] Add support for github pull request data #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code proposes a possible implementation to include support for github pull request data in ELK.
This PR extends the mappings for the GitHub raw data to enable the support for pull request data,
|
@valeriocos I think this is much better than what I propose. |
|
If everybody agrees on this structure, @aswanipranjal could you modify your PR #398 according to what is proposed in this PR? |
|
Sorry for coming late to the discussion, but I agree with you all. What I don't understand is if you propose to substitute this pr with #398 (once modified), or to follow on until this one is merged. |
|
@valeriocos @jgbarah We should merge this PR and then I can create a commit to calculate the rich PR data |
|
sorry for not being clear @jgbarah . I agree with @aswanipranjal on merging this PR and then creating a new one with the rich PR data. |
|
@acs, please merge this PR? |
|
Done! Thanks for the heads up @aswanipranjal ! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aim of this PR is to trigger the discussion about how to integrate GitHub pull request data in GrimoireLab. This PR proposes to extend GitHubOcean and GitHubEnrich to include the new data without creating a new connector. Conversely, PR #398 proposes to add a new connector to ELK.
This PR requires a modification to mordred (PR chaoss/grimoirelab-sirmordred#175) in order to allow the definition of multiple sections for the same backend (thus enabling the explotation of backends with multiple categories in a transparent way). On the other hand, PR #398 doesn't need to modify mordred, however it implies the creation of a dedicated connector for each category of a backend.
Given that both solutions have advantages and drawbacks, what are your thoughts @acs @jgbarah @aswanipranjal ?