[enriched] Add code to calculate github pull requests enriched data #401
Conversation
|
@acs, @valeriocos, @jgbarah Please review? |
| rich_pr['user_login'] = pull_request['user']['login'] | ||
| user = pull_request['user_data'] | ||
|
|
||
| if user is not None and user: |
There was a problem hiding this comment.
All the participants data must come from SH directly, We must not add it here unless we need data that is not included in SH.
There was a problem hiding this comment.
@acs that data is also being added when we enrich an issue. Should I remove that too?
There was a problem hiding this comment.
No, in both cases we need to generate the identities information from SH, like we do in the rest of enrichers. At least, the information that it is included in SH. Using the git enriched, this is done using:
- Roles to be included: https://github.com/chaoss/grimoirelab-elk/blob/master/grimoire_elk/enriched/git.py#L87
- Addition of identities information: https://github.com/chaoss/grimoirelab-elk/blob/master/grimoire_elk/enriched/git.py#L415
I need to take a look to fix how identities are filled in github enricher for issues. If you want to play with this idea and reach a PR; I will be happy to review it.
There was a problem hiding this comment.
Okay, I'll try to understand better how identities are being added in the github enricher and make a PR.
Can we merge this for now, then? Because I'd also like to add the fields for the GMD code development metrics which are dependent on github pull request enrich data.
There was a problem hiding this comment.
Yes, I think so. If it is following what is done in github issues enricher. once we fix the current one, we can fix the new one.
Added code to calculate
closes #394