Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elk] Handle aliases #510

Merged
merged 6 commits into from Nov 14, 2018
Merged

[elk] Handle aliases #510

merged 6 commits into from Nov 14, 2018

Conversation

valeriocos
Copy link
Member

This PR enhances ELK to create ad-hoc aliases for raw and enriched indexes. The aliases accepted are simple ones (names), filtered aliases are currently not supported.

@coveralls
Copy link

coveralls commented Nov 13, 2018

Pull Request Test Coverage Report for Build 1090

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 286 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 68.815%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/enriched/enrich.py 57 74.55%
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/elastic.py 68 57.95%
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/enriched/git.py 72 46.81%
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/elk.py 89 13.25%
Totals Coverage Status
Change from base Build 1089: 0.02%
Covered Lines: 4965
Relevant Lines: 7215

💛 - Coveralls

This code removes the logic to add aliases, which is moved to
elastic.py.
This code allows to support the creation of aliases when
creating an index through the ElasticSearch class. The aliases
accepted are simple ones, thus they don't include filter.
This code provides support to handle aliases in ELK.
This code provides support to handle aliases
This code replaces the hard-coded string used to set up the
name of the aoc alias with a global variable.
This code enhances the tests to allow checking that aliases are
correctly set during the raw and enriched executions.
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested.

@sduenas sduenas merged commit e1d6f43 into chaoss:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants