-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Fix documentation example error #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor detail, but looks good to me, improves consistency. Thanks!
@jgbarah Yeah, i was trying to run CoCom & CoLic backends so found these. thought these would help others who might refer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @inishchith for the PR. Overall LGTM, I would ask you to:
- if possible squash the commits in one.
- prepend each commit message with a label, for instance
[doc] Fix documentation for Cocom backend
. - include some lines in the commit message to describe its content. For instance, you could reuse the PR description (without adding the references).
@valeriocos Thanks for the review. I've |
Thank you for the quick reply @inishchith , just a minor thing about the commit message.
please change it to:
|
Fix python interface example of `CoCom` backend under documentation and parameter definition in `CoCom` class
@valeriocos Sorry for that. I've updated the commit message. |
No worries @inishchith . Thank you a lot for your PR (just merged :) ) |
CoCom
backend under documentation. Reference@jgbarah @valeriocos Please review and let me know if any changes required 馃槃