Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parent classes for classes in github_issues.py and jira.py #56

Open
aswanipranjal opened this issue May 14, 2018 · 3 comments
Open

Change parent classes for classes in github_issues.py and jira.py #56

aswanipranjal opened this issue May 14, 2018 · 3 comments

Comments

@aswanipranjal
Copy link
Contributor

Currently some classes in github_issues and jira inherit from the classes in its.py class. We should change the design and make it more consistent.
@aswanipranjal aswanipranjal changed the title Change parent class for github_issues and jira Change parent classes for classes in github_issues.py and jira.py May 14, 2018
@aswanipranjal aswanipranjal mentioned this issue May 18, 2018
Closed
@jgbarah
Copy link
Contributor

jgbarah commented May 25, 2018

My guess is that for github_issues and for jira, some of the functionality is common, and that's why they inherit from its. But yes, we can revisit the design... Any proposal?

@aswanipranjal
Copy link
Contributor Author

@jgbarah, I think we can visit this issue later when we are done with redesigning the classes and functions to calculate the Metrics.

@jgbarah
Copy link
Contributor

jgbarah commented Jul 18, 2018

Maybe it is already the moment for pushing this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgbarah @aswanipranjal