Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning Up esquery.py file #57

Closed
aswanipranjal opened this issue May 17, 2018 · 0 comments
Closed

Cleaning Up esquery.py file #57

aswanipranjal opened this issue May 17, 2018 · 0 comments

Comments

@aswanipranjal
Copy link
Contributor

aswanipranjal commented May 17, 2018 •
edited
Loading

esquery.py file still does-not completely use the elasticsearch_dsl module and has specific hard coded queries in some of the functions. It also uses outdated methods to match terms and search the indices.

This ticket is about:

  • cleaning up the file and making each function use the Classes(Search, Agg, etc) from the elasticsearch_dsl module
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue May 19, 2018
@aswanipranjal
Updated esquery.py
78d4eac 
Removed all the manually created string queries in all the functions
and replaced them with elasticsearch_dsl objects like A(aggregation),
Q(query) and Search.
Updated queries to use the current methods to search and aggregate.

Closes chaoss#57
@aswanipranjal aswanipranjal mentioned this issue May 19, 2018
Merged
@aswanipranjal aswanipranjal mentioned this issue May 27, 2018
Closed
jgbarah pushed a commit that referenced this issue May 31, 2018
@aswanipranjal @jgbarah
Updated esquery.py
91d1b53 
Removed all the manually created string queries in all the functions
and replaced them with elasticsearch_dsl objects like A(aggregation),
Q(query) and Search.
Updated queries to use the current methods to search and aggregate.

Closes #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aswanipranjal