Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS2/metrics/github_issues] Add project process functions & Metrics for github_issues #102

Merged
merged 3 commits into from Aug 7, 2018

Conversation

aswanipranjal
Copy link
Contributor

This PR:

  • updates the calculate_bmi function to handle dataframe timeseries data and calculate the ratio of closed issues/pr to opened issues/pr

  • Adds project_process function for the github_issues data source

  • Updates DaysToCloseMedian timeseries method to return the values as float values with precision upto 2 digits after the decimal

  • Adds DaysToCloseAverage class which calculates the average values for time to close days values of closed issues. It has a timeseries method same as that of DaysToCloseMedian class.

  • Adds tests and data for the BMI, DaysToCloseMedian and DaysToCloseAverage classes.

This code updates the calculate_bmi function to only handle
pandas dataframe objects.
- Add the `project_process` function to calculate the metrics under project
process section of the report.
- Update the DaysToCloseMedian class's timeseries method to return
the float values upto a precision of 2 digits after the decimal.
- Add the DaysToCloseAvarage class with the timeseries method as of
DaysToCloseMedian.
Add tests and data for the BMI, DaysToCloseAverage and
DaysToCloseMedian classes timeseries methods.
@aswanipranjal
Copy link
Contributor Author

@valeriocos please review?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 258

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.4%) to 61.894%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/chaoss/grimoirelab-manuscripts/manuscripts2/elasticsearch.py 8 85.9%
/home/travis/build/chaoss/grimoirelab-manuscripts/manuscripts2/metrics/github_issues.py 8 90.63%
Totals Coverage Status
Change from base Build 257: 1.4%
Covered Lines: 1111
Relevant Lines: 1795

💛 - Coveralls

Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriocos valeriocos merged commit 2616d43 into chaoss:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants