Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS2/README] Update README with instructions to generate the report #109

Merged
merged 1 commit into from Aug 11, 2018

Conversation

aswanipranjal
Copy link
Contributor

@aswanipranjal aswanipranjal commented Aug 9, 2018

This PR updates the readme with instructions to create the report.

merge after #108

@coveralls
Copy link

coveralls commented Aug 9, 2018

Pull Request Test Coverage Report for Build 276

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.356%

Totals Coverage Status
Change from base Build 275: 0.0%
Covered Lines: 1133
Relevant Lines: 1817

💛 - Coveralls

@aswanipranjal
Copy link
Contributor Author

@jgbarah @valeriocos please review?


You can produce the github_issues index using the following command:
```bash
p2o.py --enrich --index github_issues_raw --index-enrich github_issues -e http://localhost:9200 --no_inc --debug --db-host localhost --db-sortinghat <db name> --db-user root github <owner> <repo name> -t <token>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is <db user> instead of "root". Please use \ too split the line so that it feets in about 80 char width.


And a github_prs index using this command:
```bash
p2o.py --enrich --index github_prs_raw --index-enrich github_prs -e http://localhost:9200 --no_inc --debug --db-host localhost --db-sortinghat <db name> --db-user root github <owner> <repo name> -t <token> --category pull_request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is <db user> instead of "root". Please use \ too split the line so that it feets in about 80 char width.


The git index has no changes and can be produced as follows:
```bash
p2o.py --enrich --index git_raw --index-enrich git -e http://localhost:9200 --no_inc --debug --db-host localhost --db-sortinghat <db name> --db-user root git <repository url>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use \ too split the line so that it feets in about 80 char width.

p2o.py --enrich --index git_raw --index-enrich git -e http://localhost:9200 --no_inc --debug --db-host localhost --db-sortinghat <db name> --db-user root git <repository url>
```

**NOTE:** If you don't know how or what [Sortinghat](https://github.com/chaoss/grimoirelab-sortinghat) is, please [go through the tutorial](https://grimoirelab.gitbooks.io/tutorial/sortinghat/intro.html). Sortinghat helps us manage the identities of the contributors and manitainers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add something like "But in this case, you don't really need to know about it if you don't need identity management, which for a first try, likely you don't need".

First, run:

```bash
python setup.py install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ pip install .


Now, once the indices mentioned above have been created, you can run the following command to generate the report:
```bash
manuscripts2 -n <name of the report/repository being analysed> -d <name of the directory to store the data in> -s <start date from which the repo has to be analysed> -e <end date upto which the repo is to be analysed> -i <time interval> -u <elasticsearch url where all the indices are being stored> --data-sources <the data sources from which the data is to be gathered from> --indices <custom index names to get the data from> -l <custom logo to be applied to the report>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better if you use shorter names for the labels, such as <repo_name>. In a following paragraph, you can make it clear that <repo_name> is the "name of the project/repository being analysed" (note project instead of report). But also include an example (for example in this case, "CHAOSS").

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain also which data sources are possible (with the correct labels), and how the correspond, one by one, with the indexes.

The actual report pdf will be, you guessed it right, a file named `report.pdf`.

---

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add at least a complete example. You could for example produce a complete example for producing a report of chaoss/grimoirelab-manuscripts and chaoss/grimoirelab-perceval (just to have at least two repositories), from running p2o.py to running manuscripts2.

This code adds instructions on how to create the PDF report using manuscripts2
as well as how the tests can be run.
Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriocos valeriocos merged commit deb3db2 into chaoss:master Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants