[manuscripts2] Make the functions: get_aggs and get_timeseries, methods of the Query class #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create flush_aggregations method to empty the aggregation dict
jgbarah
approved these changes
Jul 18, 2018
aswanipranjal
added a commit
to aswanipranjal/grimoirelab-manuscripts
that referenced
this pull request
Jul 18, 2018
- Now calling get_aggs as a method of Query class and not as an independent function
jgbarah
pushed a commit
that referenced
this pull request
Jul 19, 2018
- Now calling get_aggs as a method of Query class and not as an independent function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the functions
get_aggsandget_timeseriesand makes them methods of theQueryclass in new_functions.py file