Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update failing tests due to change in grimoirelab-preceval repository #79

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

aswanipranjal
Copy link
Contributor

This PR updates the git data that is stored for the comparision with the fresh data fetched from the perceval repo.

WHY?:
The tests enrich grimoirelab-perceval git data to test the functions and by merging old PRs in perceval it changed the fresh data that was being fetched from the preceval repo and thus test were failing.

We are using git data source because in using github data source will result in long time for the tests to run as it requires a github token to query the data and we don't have one.

The tests enrich grimoirelab-perceval git data to test the functions.
merging old PRs in perceval changed the fresh data that was being
fetched from the preceval repo and thus test were failing.
This code updates the stored data by adding fresh commits that were
added to perceval.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 191

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.309%

Totals Coverage Status
Change from base Build 189: 0.0%
Covered Lines: 849
Relevant Lines: 1535

💛 - Coveralls

@aswanipranjal
Copy link
Contributor Author

@jgbarah please have a look?

Copy link
Contributor

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving the comment, but however, i think we need to improve how tests are done by either:

  • Use "frozen" enriched indexes, that are uploaded to Elasticsearch before the test is run. Since the enriched index will always be exactly the same, output should be, too, or
  • Use the Perceval cache, so that instead of going to the real data source, Perceval just gets the data that is previously feed in its cache, or
  • Use a git repository in a tar file, so that before running the tests, the git repo is untarred and tools are run in it to produce the enriched index. This is particular to git.

Or maybe a combination of the above.

@aswanipranjal please open a new issue about this (although I'm merging this code, since it is better than what we had).

@jgbarah jgbarah merged commit e7e4d9d into chaoss:master Jul 23, 2018
@aswanipranjal
Copy link
Contributor Author

Thank you @jgbarah!
I will update the tests to use a frozen index, as I am trying to do in the tests for #80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants