Add functionality to calculate project_activity for git #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code adds the functionality to calculate the project activity section of the report for the git data source
- This code adds the tests for the timeseries metrics generated by Commits class - It also adds the data for the same
Pull Request Test Coverage Report for Build 241
💛 - Coveralls |
|
@valeriocos can you please review this and the other two PRs too? |
|
The PR looks good to me, but I don't understand why the coverage has decreased. Do you know why? Have you tried to run coveralls (https://pypi.org/project/coveralls/) locally to see which lines are missing? |
|
I haven't tried Coveralls, but I am on it! Thanks! |
|
|
|
Thank you, @aswanipranjal |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to calculate project_activity section of the report for the git data source using the project_activity function.
It generates the timeseries aggregations for Commits class (Authors class already generates a timeseries which is being added to the function directly) for a given time interval.
This PR also adds tests and data for the timeseries generated.