Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perceval] Update license and copyright information #624

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

vchrombie
Copy link
Member

@vchrombie vchrombie commented Mar 8, 2020

This PR updates license information for the remaining source code files in Perceval.
This is an extension of #623.

I tried updating this using the tool, vchrombie/grimoirelab-scripts.

@vchrombie vchrombie force-pushed the test-copyright-script branch 2 times, most recently from e34cbf0 to 7f0d599 Compare March 8, 2020 20:22
@valeriocos
Copy link
Member

valeriocos commented Mar 8, 2020

can you update the commit description by adding some info about the files modified (e.g., tests, bin and setup.py)? thanks. A possible description could be:

This commit updates the license information for every test file in Perceval, the setup.py and bin/perceval. The author names are also updated using a script.

Please, consider to submit also PRs to ELK and mordred, and the other components :)

@vchrombie
Copy link
Member Author

Please, consider to submit also PRs to ELK and mordred, and the other components :)

Sure @valeriocos.

@vchrombie vchrombie marked this pull request as ready for review March 11, 2020 01:20
@vchrombie
Copy link
Member Author

I just had one doubt in this PR. #624 (comment)

The rest all looks good to me.

@valeriocos, WDYT?

@valeriocos
Copy link
Member

Please @vchrombie ping me when the PR is ready for review, thanks!

This commit updates the license information for every
test file in Perceval, the setup.py and bin/perceval.
The author names are also updated using a script.

Signed-off-by: Venu Vardhan Reddy Tekula <venuvardhanreddytekula8@gmail.com>
@coveralls
Copy link

coveralls commented Mar 12, 2020

Coverage Status

Coverage remained the same at 97.663% when pulling 07b0998 on vchrombie:test-copyright-script into 75be46b on chaoss:master.

@vchrombie
Copy link
Member Author

Hi @valeriocos

I updated the PR and I think it is in good shape now. The Travis CI build also passed. 😌
You can review it now.

Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vchrombie

@valeriocos valeriocos merged commit 807e640 into chaoss:master Mar 13, 2020
@vchrombie vchrombie deleted the test-copyright-script branch November 3, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants