Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubt about how to configure GrimoireLab / mordred.cfg #145

Closed
jsmanrique opened this issue May 10, 2018 · 5 comments
Closed

Doubt about how to configure GrimoireLab / mordred.cfg #145

jsmanrique opened this issue May 10, 2018 · 5 comments
Labels

Comments

@jsmanrique
Copy link

I am deploying a new demo of GrimoireLab and I would like to test affiliations information management.

As first step, I've seen there are dedicated params in mordred.cfg about this. I've been reading the docs. But, it's not clear for me if which params I need to touch. Let me explain why.

If I've understood right, affiliate, load_orgs, and orgs_file, are the main params. And I plan to use this orgs.json file as data source:

And this is what the doc says:

affiliate (bool: True): Affiliate identities to organizations (Required)
load_orgs (bool: False):
orgs_file (str: None): File path with the organizations to be loaded in Sortinghat

So, without any further docs (I've not found anything else about these params anywhere), I think the values should be:

affiliate: True
load_orgs: True
orgs_file: orgs.json

But, then, I check current examples provided in the main GrimoireLab repository (1, 2) and I see this:

affiliate: True
load_orgs: false
orgs_file: orgs.json

Could someone clarify why or how is the right way to work?

My objective is that at least, people committing using a corporate account email domain are rightly affiliated.

Thanks!

@canasdiaz
Copy link
Contributor

It is not well documented @jsmanrique . The affiliate parameter allows to executiong of the SortingHat method affiliate which uses the available information (in the database) to guess the organization affiliation for each identity.

The other two parameters are thought to allow to load new organizations based on a file. So, you could have affiliate set to True and the load_orgs set to False, but this way the json file would not be loaded into the identities database.

Let me know whether you understand my explanation :)

@jsmanrique
Copy link
Author

Thanks @sanacl. Understood. So based in your explanation, the documented configuration in GrimoireLab tutorial makes no sense:

affiliate: True
load_orgs: false
orgs_file: orgs.json

I mean, what's the sense of setting load_orgs to false (it won't load any organizations json file), and set an orgs_file?

@canasdiaz
Copy link
Contributor

Thanks @sanacl. Understood. So based in your explanation, the documented configuration in GrimoireLab tutorial makes no sense:

affiliate: True
load_orgs: false
orgs_file: orgs.json

I mean, what's the sense of setting load_orgs to false (it won't load any organizations json file), and set an orgs_file?

The only point of doing that is no loading again data that is already loaded... But yes, it makes the explanation more complex and it is not well explained

@canasdiaz
Copy link
Contributor

I guess we can close this ticket @jsmanrique

@jjmerchante
Copy link
Contributor

Closing this ticket because the question is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants