Relocate studies aliases #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Studies aliases shouldn't be made to point to data source indices directly. Otherwise they could end pointing to indices that don't have studies data. And the studies visualizations would show wrong data. Instead, since they are studies, Mordred will automatically create these aliases pointing to the correct indices. However, we'd like that these aliases are listed in a fake data source, so we can list all possible enriched aliases for other purposes. Signed-off-by: Angel Jara <ajara@bitergia.com>
Pull Request Test Coverage Report for Build 2449356574
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Studies aliases shouldn't be made to point to data source indices
directly. Otherwise they could end pointing to indices that don't have
studies data. And the studies visualizations would show wrong data.
Instead, since they are studies, Mordred will automatically create
these aliases pointing to the correct indices.
However, we'd like that these aliases are listed in a fake data source,
so we can list all possible enriched aliases for other purposes.
Signed-off-by: Angel Jara ajara@bitergia.com