Goodbye python27 #150
Merged
Goodbye python27 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
requested changes
Jun 19, 2018
There was a problem hiding this comment.
Everything looks OK but there are other things related with Python 2.7 that should be removed.
assertRaisesRegexpis deprecated; replace it byassertRaisesRegex- all
__future__imports can be safely removed ConfigParserimports can also be removed;configparseris the name of the module in Python3.- Check line 25 in
sortinghat/exceptions.py tests/test_exceptions.pyandtests/test_parser_gitdm.pyhave strings with the prefixu"...". This is not longer needed.- MySQLdb is not compatible with Python3.
db/database.pyreferences it. Documentation too. OperationalErroris not raised whenpymsqlis used.
References in the documentation should be also removed.
Please also rebase the PR. There are references to old code.
valeriocos
force-pushed
the
goodbye-python27
branch
2 times, most recently
from
3751f2e
to
61b811a
Compare
sduenas
requested changes
Jun 20, 2018
sortinghat/cmd/add.py
Outdated
| """%(prog)s add [--name <name>] [--email <email>] [--username <user>] [--source <src>] [--uuid <uuid>] | ||
| [--matching <matcher>] [--interactive]""" | ||
| ADD_COMMAND_USAGE_MSG = """%(prog)s add [--name <name>] [--email <email>] | ||
| [--username <user>] [--source <src>] [--uuid <uuid>] [--matching <matcher>] [--interactive]""" |
There was a problem hiding this comment.
Don't remove these blank spaces. They're there for a pretty printing when -h, --help is in use.
sortinghat/cmd/profile.py
Outdated
| """%(prog)s profile [--name <name>] [--email <email>] [--gender <gender] | ||
| [--country <code>] [--bot | --no-bot] <uuid>""" | ||
| PROFILE_COMMAND_USAGE_MSG = """%(prog)s profile [--name <name>] [--email <email>] | ||
| [--gender <gender] [--country <code>] [--bot | --no-bot] <uuid>""" |
sortinghat/exceptions.py
Outdated
| def __str__(self): | ||
| return self.__unicode__().encode('utf8') | ||
| def __str__(self): | ||
| return self.__unicode__() |
There was a problem hiding this comment.
Method __unicode__ can be removed. This method only needs to return self.msg now.
valeriocos
force-pushed
the
goodbye-python27
branch
from
61b811a
to
2b458f7
Compare
This code removes support for Python 2.7 from sortinghat. Thus, misc, bin, sortinghat and tests folders plus the travis.yml are modified accordingly.
This code fixes several flake8 errors to make the code compatible with PEP8 standard. Thus, the folders tests, bin, sortinghat, misc are modified accordingly.
valeriocos
force-pushed
the
goodbye-python27
branch
from
2b458f7
to
bffcc97
Compare
sduenas
approved these changes
Jun 20, 2018
sduenas
added a commit
that referenced
this pull request
Jun 20, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits addresses #148. Thus, it removes support for Python 2.7