Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Adapt tests to run with setup.py test #154

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

jgbarah
Copy link
Contributor

@jgbarah jgbarah commented Jun 24, 2018

In the migration to get all of GrimoireLab modules to run the tests via setup.py, some stuff waas needed, which is in this patch:

  • Adaption of setup.py itself, including testing dependencies, adapting some other details in the script.
  • Adaption of tests to be run from the parent directory.
  • Create the database to use for testing, and remove it after the tests.
  • New option in tests.conf, for running that code to create the database or not.
  • Adapt the README.md to show how tests are run.
  • Adapt .travis.yml to run with setup.py (and update it a bit).

In the process for adapting the tests to be run from the parent directory, their portability was increased: now they should run also in systems where "/" is not the path separator.

In the migration to get all of GrimoireLab modules to run the
tests via setup.py, some stuff waas needed, which is in this
patch:

* Adaption of setup.py itself, including testing dependencies,
adapting some other details in the script.
* Adaption of tests to be run from the parent directory.
* Create the database to use for testing, and remove it after the
tests.
* New option in tests.conf, for running that code to
create the database or not.
* Adapt the README.md to show how tests are run.
* Adapt .travis.yml to run with setup.py (and update it a bit).

In the process for adapting the tests to be run from the parent
directory, their portability was increased: now they should run
also in systems where "/" is not the path separator.
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants