[matching-email] Support blacklist when strict matching is False #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriocos
force-pushed
the
issue-228
branch
from
709ef9c
to
62be737
Compare
This code refactors the code to support the blacklisting of emails when the strict mode is set to `False`. Thus, the method `_check_blacklist` is created and the method `check_email` is modified accordingly (by removing the logic that blacklists emails). Tests have been added accordingly. Signed-off-by: Valerio Cosentino <valcos@bitergia.com>
This code removes the method `_filter_emails` which isn't used either in sortinghat or in other grimoirelab components. Signed-off-by: Valerio Cosentino <valcos@bitergia.com>
valeriocos
force-pushed
the
issue-228
branch
from
62be737
to
b3f7833
Compare
|
please @sduenas check it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code addresses #228, thus refactors the code to support the blacklisting of emails when the strict mode is set to
False. The method_check_blacklistis created and the methodcheck_emailis modified accordingly (by removing the logic that blacklists emails).Tests have been added accordingly.
Furthermore this PR removes the method
_filter_emailswhich isn't used either in sortinghat or in other grimoirelab components.