[ui] add TeamModal component #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evamillan
reviewed
Aug 11, 2021
There was a problem hiding this comment.
Thanks for the PR, Rashmi, I've got a few comments.
- I get some warnings when I run
yarn serve, runningyarn lint --fixshould fix most of them. - Can you align the edit and delete buttons on the modal? Adding the
align-centerclass to the row they're in will probably do the trick. Also, the "add a new team" button looks a bit like plain text, you can maybe use the same one as the "add domain" or "add organization" from the other modals. - I thought we would display the number of teams and the top level ones on the organizations table, it could be useful to have that bit of information there. In any case, the expanded view can look tidier if the "Domains" and "Teams" text has the same size and is aligned.
- When I add a subteam on the modal, the team is added to the database but the interface is not updated, you need to reload the page to see it.
I also left some comments on the code.
Rashmi-K-A
force-pushed
the
ui
branch
4 times, most recently
from
64b4714
to
631fc7b
Compare
|
The changes look good to me, but there are still some lint warnings, can you take a look at them @Rashmi-K-A? |
Done @evamillan |
This commit adds a modal component to the Organizations table. On clicking the View teams button in the table, this modal opens up displaying all the top level teams of the organization. Signed-off-by: Rashmi-K-A <k.a.rashmi04@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a modal component to the Organizations
table. On clicking the View teams button in the table,
this modal opens up displaying all the top level teams
of the organization.
Signed-off-by: Rashmi-K-A k.a.rashmi04@gmail.com