Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitdm] Skip invalid format lines #615

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

zhquan
Copy link
Member

@zhquan zhquan commented Apr 20, 2022

This change skips invalid formatting lines instead of raising an
error. This way it will keep executing the file.

Example of invalid lines:

  • bitergia.com B#itergia
  • jsmith.example.com Example#
  • jsmith.example.com Example Company < 2010-01-01#

Test updated accordingly.

Signed-off-by: Quan Zhou quan@bitergia.com

@zhquan zhquan force-pushed the skip_sharp_inline branch 2 times, most recently from e13bc84 to d37129d Compare April 20, 2022 13:32
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commit what really does is to skip those lines with an invalid format. You should reword the commit message an the changelog entry (also the filename). Besides that, the PR looks ok to me.

@zhquan zhquan changed the title [gitdm] Skip lines with '#' in the middle of the line [gitdm] Skip invalid format lines Apr 20, 2022
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let me know what you think about my change on the changelog entry.

This change skips invalid formatting lines instead of raising an
error. This way it will keep executing the file.

Example of invalid lines:
- bitergia.com	B#itergia
- jsmith.example.com  Example#
- jsmith.example.com  Example Company < 2010-01-01#

Test updated accordingly.

Signed-off-by: Quan Zhou <quan@bitergia.com>
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas closed this in 9775a54 May 5, 2022
@sduenas sduenas merged commit 9775a54 into chaoss:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants