Fix unify individuals with the same username and source #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves an issue where the "match source" option was being applied to emails and names. With this update, this option will now only apply to usernames. Additionally, users can use email and name simultaneously. Fixes chaoss#875 Signed-off-by: Jose Javier Merchante <jjmerchante@bitergia.com>
sduenas
requested changes
Jun 11, 2024
There was a problem hiding this comment.
It works great. Thanks for the PR.
I have a request though. Would you mind to add this line to the devel config? When testing everything the devel settings didn't work because that setting is not set.
MULTI_TENANT = os.environ.get('SORTINGHAT_MULTI_TENANT', 'False').lower() in ('true', '1')
This commit includes MULTI_TENANT variable in the devel configuration file. Signed-off-by: Jose Javier Merchante <jjmerchante@bitergia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where the "match source" option was being applied to emails and names. With this update, this option will now only apply to usernames. Additionally, users can use email and name simultaneously.
Fixes #875