[docker] Add logrotate to docker #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, @arnonm-intel. Tests are failing because of the DCO thing. Please check "DCO and Sign-off contributions" in CONTRIBUTING.md. Now, wrt the patch itself. I like the idea of keeping logs under control, but at the same time I'm a bit reluctant to have it because of the added dependency (on |
|
We use the containers to run the stack for months on end. As a result, the log file continues to grow and eventually hits a limit
I saw two options here – either add a rotate functionality to SirMordred, or add it to the container in the simplest way – a logrotate
From: Jesus M. Gonzalez-Barahona <notifications@github.com>
Sent: Monday, March 02, 2020 10:54
To: chaoss/grimoirelab <grimoirelab@noreply.github.com>
Cc: Meshoulam, Arnon <arnon.meshoulam@intel.com>; Mention <mention@noreply.github.com>
Subject: Re: [chaoss/grimoirelab] [docker] Add logrotate to docker (#303)
Thanks a lot, @arnonm-intel<https://github.com/arnonm-intel>. Tests are failing because of the DCO thing. Please check "DCO and Sign-off contributions" in CONTRIBUTING.md<https://github.com/chaoss/grimoirelab/blob/master/CONTRIBUTING.md#dco-and-sign-off-for-contributions>.
Now, wrt the patch itself. I like the idea of keeping logs under control, but at the same time I'm a bit reluctant to have it because of the added dependency (on logrotate). Anyone else has an opinion on this? (Any further comment by you @arnonm-intel<https://github.com/arnonm-intel> is welcome, of course).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#303?email_source=notifications&email_token=AHOSQLHVFB5UBQY2SCPW4J3RFNX2DA5CNFSM4K7FCE62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENOOM4Y#issuecomment-593290867>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHOSQLCAI4KX4VMWKJBBA5DRFNX2DANCNFSM4K7FCE6Q>.
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
|
|
Signature fixed. Can you retrigger it? |
I'm not seeing new commits with signature... Maybe you didn't push them or something? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logrotate to docker and set to keep 3 copies of /log/all.log at 100MB each