Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Fix some details of the images. #52

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

jgbarah
Copy link
Contributor

@jgbarah jgbarah commented Jan 6, 2018

Now images for grimoirelab/factory, grimoirelab/installed, and grimoirelab/full are produced from the root dir of the repo. This allows to have access to the utils and releases directories
when needed.

.dockerignore to avoid uploading to the docker daemon a lot of stuff in those directories, which is not needed.

Fix to ensure that grimoirelab/full works, by waiting until the Kibana index in Elasticserarch is ready.

Updated docs.

Now images for grimoirelab/factory, grimoirelab/installed,
and grimoirelab/full are produced from the root dir of the repo.
This allows to have access to the utils and releases directories
when needed.
.dockerignore to avoid uploading to the docker daemon a lot
of stuff in those directories, which is not needed.
Fix to ensure that grimoirelab/full works, by waiting until
the Kibana index in Elasticserarch is ready.
Updated docs.
@jgbarah jgbarah requested a review from acs January 6, 2018 00:58
@jgbarah
Copy link
Contributor Author

jgbarah commented Jan 10, 2018

????

Copy link
Member

@acs acs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acs
Copy link
Member

acs commented Jan 10, 2018

@jgbarah sorry about the delay. I let you to merge the PR

@jgbarah jgbarah merged commit 819051c into chaoss:master Jan 10, 2018
@jgbarah
Copy link
Contributor Author

jgbarah commented Jan 10, 2018

Then, I merge it myself. Thanks for the approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants