Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing wg-common repository #114

Closed
ritik-malik opened this issue Apr 14, 2021 · 6 comments
Closed

Standardizing wg-common repository #114

ritik-malik opened this issue Apr 14, 2021 · 6 comments

Comments

@ritik-malik
Copy link
Member

Hi,

Since there is a constant effort to standardize the WG repositories, as listed here,
the wg-common repository contains a directory called template-folder which defines the metrics template.
Considering the fact that we already have a dedicated repository for metrics, should we remove this directory?

@GeorgLink
Copy link
Member

Thanks @ritik-malik

I agree with removing the metric template since it's duplicating what we already have.

The naming convention would be interesting to add to the Community Handbook on the metric page. Can you please make sure that knowledge is preserved before we remove it here?

@ritik-malik
Copy link
Member Author

Sure @GeorgLink ,

Should I add an extra sub heading for the naming convention in the metric page?
Also, do we need an extra heading in Working Group page for standard WG repository template as we discussed earlier?

@GeorgLink
Copy link
Member

GeorgLink commented Apr 14, 2021 via email

@ritik-malik
Copy link
Member Author

ritik-malik commented Apr 14, 2021

Thank you for creating the page @GeorgLink,
I'll add that repository structure to it (hoping the doc is finalized)

As for the naming convention, I think we could add it to all 3 locations to be on the safe side,
as it would also be helpful for a new contributor looking for guidelines (rather than redirecting user to specific page)
Nevertheless, if you want it in some specific file, please let me know and I will do the same

@GeorgLink
Copy link
Member

GeorgLink commented Apr 15, 2021 via email

@geekygirldawn
Copy link
Member

PR Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants