Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate Comments (Reviews Declined) #283

Closed
klumb opened this issue Dec 30, 2019 · 7 comments
Closed

Release Candidate Comments (Reviews Declined) #283

klumb opened this issue Dec 30, 2019 · 7 comments

Comments

@klumb
Copy link
Member

klumb commented Dec 30, 2019

This issue was created to collect comments about the upcoming metrics release.

This thread is for comments about Reviews Declined

GitHub location: https://github.com/chaoss/wg-evolution/blob/master/metrics/Reviews_Declined.md

See all release candidates of metrics are at:
https://chaoss.community/metrics-202001/

@germonprez
Copy link
Contributor

"Resources" should be "References"

@germonprez
Copy link
Contributor

Un-bold "Question"

@ccarterlandis ccarterlandis self-assigned this Jan 14, 2020
@ccarterlandis
Copy link
Contributor

@germonprez fixed by #304

@foundjem
Copy link
Collaborator

I have a concern about this metric. For example, (i) reviews that authors themselves abandon; this will not also be merged in the codebase, similarly, (ii) declined can also mean that the author(s) did not satisfy the reviewers' requirements before they could accept and merge the patch, etc.

Signed-off-by: Armstrong Foundjem foundjem@ieee.org

@klumb
Copy link
Member Author

klumb commented Jan 25, 2020

Is this metric ready for release?

@foundjem do you have specific edits in mind?

@ccarterlandis
Copy link
Contributor

Barring any specific edits @foundjem may have in mind, I would say it's ready!

@klumb
Copy link
Member Author

klumb commented Jan 25, 2020

I am marking this for release. If we need to address unresolved comments, we can do so in the next release.

@klumb klumb closed this as completed Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants