-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create getAllEvents probe #6
Comments
The work will include updating the usage in the README, and also providing a short sample experiment with its usage incorporated in a |
Parameters would be a window of time (start, end) and an optional delay parameter, defaulted to 5 seconds, as Instana's model can be up to 5 seconds behind the feeds from the target system. |
I'd like to refine this method so that it is called
I'd also like to propose that the Finally it would also be possible to support only As |
Python doesn't really have the concept of overloading functions. You do use default values indeed. You could achieve this with singledispatch but I'm afraid this will make the code harder to read in this case. I would stick with keeping a single function with default values. Note also, Finally, might be worth using dateparser to allow users to say "2 minutes ago" which reads more fluently.
|
Signed-off-by: Grant Tarrant-Fisher <grant@chaosiq.io> Closes #6
Signed-off-by: gtfisher <grant@tarrant-fisher.co.uk> Closes #6
Closes #6 Signed-off-by: gtfisher <grant@tarrant-fisher.co.uk>
Closes #6 Signed-off-by: gtfisher <grant@tarrant-fisher.co.uk>
The probe's signature will likely look like:
And simply return the full json in a string to be used to enrich an experiment's journal. This probe is unlikely to be useful to steady-state hypothesis work.
The underlying API call will implement:
The text was updated successfully, but these errors were encountered: