-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating kubernetes api version to support the latest apps/v1
version
#65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 77.23% 77.23%
=======================================
Files 4 4
Lines 325 325
=======================================
Hits 251 251
Misses 74 74 Continue to review full report at Codecov.
|
Signed-off-by: rahulsharma <rahulsharmaoist@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
A few questions:
- could you please add a changelog entry to explain why this change is needed please?
- could you try to explain what may happen for older clusters? what's the minimal version of the Kubernetes API does this work against? I've seen the go code making a call first to the new endpoint and, when it fails, falling back to the old API. should we follow the same path?
I'm surprised tests weren't impacted. maybe we are missing some...
@Lawouach Sure will update this PR with changelog later today. |
Makes sense and your fix seems the right one. Wondering about backward compatibility. |
previous version of |
True although this isn't my philosophy here. But, reading your link again, they mention the I might work on a change, after yours, that will try to support both by looking up the version of the server first. |
Sounds good |
This PR is fix related to the issue #63 & #62 . A part of these issues have been already addressed in Pull request : #53
Changes include:
chaosk8s\actions.py
&chaosk8s\probes.py