Fix CA cert passing to k8s client #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ykskb <yoheikusakabe@gmail.com>
hendrikKahl
pushed a commit
to hendrikKahl/chaostoolkit-kubernetes
that referenced
this pull request
Sep 29, 2020
Signed-off-by: ykskb <yoheikusakabe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ykskb yoheikusakabe@gmail.com
It seems CA cert can't be passed to k8s client from secret/env as the current codes writes on
cert_fileproperty of kube client configuration which gets overwritten byKUBERNETES_CERT_FILEvalue. This PR is to fix this.