Update tmacd-promotion

One of the cases stopped printing out a rank change array
(due to the resolution of issue #16275).

See issue #16300 which asks questions about the current output.

modules/internal/ChapelArray.chpl

@@ -5068,6 +5068,7 @@ module ChapelArray {
     // instances
     // TODO: can we make this domain constant by passing an argument to the
     // initializer?
+    // MPPF: Should this shape be un-view'd?
     var shape = new _domain(ir._shape_);
 
     // Important: ir._shape_ points to a domain class for a domain

test/arrays/shapes/tmacd-promotion.chpl

@@ -1,12 +1,48 @@
 config const n = 2;
 var b: [0..n+1, 0..n+1, 0..1] int;
 
-const N = b[0..n-1, 0..n-1, 0];
-writeln("====== N ======");
-writeln(N);
-writeln(N.type:string);
-
-const NN = b[0..n-1, 0..n-1, 0] + b[0..n-1, 2..n+1, 0];
-writeln("====== NN =====");
-writeln(NN);
-writeln(NN.type:string); 
+proc initb() {
+  for i in 0..n+1 {
+    for j in 0..n+1 {
+      for k in 0..1 {
+        b[i,j,k] = 10000*i + 100*j + k;
+      }
+    }
+  }
+}
+
+{
+  initb();
+  const N = b[0..n-1, 0..n-1, 0];
+  b = 0;
+  writeln("====== const N ======");
+  writeln(N);
+  writeln(N.type:string);
+}
+
+{
+  initb();
+  const NN = b[0..n-1, 0..n-1, 0] + b[0..n-1, 2..n+1, 0];
+  b = 0;
+  writeln("====== const NN =====");
+  writeln(NN);
+  writeln(NN.type:string);
+}
+
+{
+  initb();
+  const ref N = b[0..n-1, 0..n-1, 0];
+  b = 0;
+  writeln("====== const ref N ======");
+  writeln(N);
+  writeln(N.type:string);
+}
+
+{
+  initb();
+  const ref NN = b[0..n-1, 0..n-1, 0] + b[0..n-1, 2..n+1, 0];
+  b = 0;
+  writeln("====== const ref NN =====");
+  writeln(NN);
+  writeln(NN.type:string);
+}

test/arrays/shapes/tmacd-promotion.good

@@ -1,8 +1,15 @@
-====== N ======
-0 0
-0 0
+====== const N ======
+0 100
+10000 10100
+[domain(2,int(64),false)] int(64)
+====== const NN =====
+200 400
+20200 20400
 [ArrayViewRankChangeDom(2,int(64),false,3*bool,3*int(64),int(64),unmanaged ArrayViewRankChangeDist(unmanaged DefaultDist,3*bool,3*int(64)))] int(64)
-====== NN =====
+====== const ref N ======
 0 0
 0 0
 [ArrayViewRankChangeDom(2,int(64),false,3*bool,3*int(64),int(64),unmanaged ArrayViewRankChangeDist(unmanaged DefaultDist,3*bool,3*int(64)))] int(64)
+====== const ref NN =====
+0 0 0 0
+iterator