Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapel-py: Add a CHPL_ variable to auto-build chapel-py #24871

Closed
DanilaFe opened this issue Apr 16, 2024 · 0 comments · Fixed by #24912
Closed

chapel-py: Add a CHPL_ variable to auto-build chapel-py #24871

DanilaFe opened this issue Apr 16, 2024 · 0 comments · Fixed by #24912
Labels
area: Python bindings For things related to chapel-py, chpl-language-server, chplcheck, etc. area: Tools

Comments

@DanilaFe
Copy link
Contributor

DanilaFe commented Apr 16, 2024

Much like chpldoc, chapel-py is not built by default; also much like chpldoc, chapel-py is used in some tests in the test/ directory, and not having an up-to-date build can cause these tests to fail. chpldoc solves this problem by having an environment variable that always builds it when a regular make is invoked. chapel-py does not have a variable like that, and I consistently forget to rebuild it when running paratests. It would be nice if we had a variable like this for chapel-py.

@DanilaFe DanilaFe added area: Tools area: Python bindings For things related to chapel-py, chpl-language-server, chplcheck, etc. labels Apr 16, 2024
DanilaFe added a commit that referenced this issue Apr 23, 2024
#24912)

Fixes #24871.

This PR adds two more environment variables,
`CHPL_ALWAYS_BUILD_CHAPEL_PY` and `CHPL_ALWAYS_BUILD_LANGUAGE_SERVER`,
to build `chapel-py` and `chpl-language-server` on `make -j32`. This
will help in situations such as setting off `paratests`: simply running
`make -j32` will be enough to make sure that Python environment is up to
date, ensuring that `chplcheck` (etc.) tests run. This should help catch
`chplcheck` bugs as they come up.

Reviewed by @jabraham17 -- thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Python bindings For things related to chapel-py, chpl-language-server, chplcheck, etc. area: Tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant