Toml header parsing fix

[ankushbhardwxj]

• Fixed error in regex of TOML header parsing
• Rewrote tests and removed future added in Mason fixes from #16091 and #16078 #16132

[ankushbhardwxj]

@ben-albrecht Please review this & let me know for any changes.
Confirming testing passes on my end

> start_test test/mason test/library/packages/UnitTest test/library/packages/TOML
[Test Summary - 200728.003551]
[Summary: #Successes = 148 | #Failures = 0 | #Futures = 0 | #Warnings = 0 ]
[Summary: #Passing Suppressions = 0 | #Passing Futures = 0 ]
[END]

[ben-albrecht]

@ankingcodes - thanks for the quick turn-around. I have some testing feedback inline.

[ankushbhardwxj]

@ben-albrecht made changes requested.

[ankushbhardwxj]

@ben-albrecht - Made the changes requested here. Also, modified TomlTest.chpl.
Confirming testing passes on my end:

[Test Summary - 200728.212300]
[Summary: #Successes = 23 | #Failures = 0 | #Futures = 0 | #Warnings = 0 ]
[Summary: #Passing Suppressions = 0 | #Passing Futures = 0 ]
[END]

We can also add a GSOC label here.

[ben-albrecht]

Passes local testing. I have 1 question about our implementation, but looks good otherwise!

[ben-albrecht]

Will this do the right thing if we have mixed quotes, e.g.

[foo."a.b.c".bar]

If so, it could be useful to include this in the test cases.

Also, I suspect we don't yet handle escaped quotes, e.g.

[foo.\"a.b.c]

but I'm OK to defer that for future work.

[ankushbhardwxj]

[foo."a.b.c".bar]

No, our current implementation doesn't support this. We basically count the number of periods before a quote is encountered and split that many times. I'm not sure how we could handle this case, since we cannot differentiate periods before and after the quotes, using our inbuilt split function.

[ankushbhardwxj]

I believe we will need to get rid of using the inbuilt split function and create a new function which would avoid periods inside of quotes.

[ben-albrecht]

I believe we will need to get rid of using the inbuilt split function and create a new function which would avoid periods inside of quotes.

I would support this approach. Let's discuss in today's call.

[ben-albrecht]

Adding a WIP label to help me keep track of which PRs are waiting on me. IIRC, we are pursuing the parsing / splitting fixes in this PR.

[ben-albrecht]

@ankingcodes - Should we close this PR until you have time to come back to it? I'm not sure if you'd pick up from this branch or start a new PR when you get around to the bigger parsing/splitting changes.

[ben-albrecht]

@ankingcodes - I am going to close this PR until we have a chance to revisit the design & implementation.