Fix some issues with new tests locking in bug fixes #17320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not think to run memleaks testing on these tests, and hadn't realized that they hadn't freed their unmanaged classes. Do so here. There was a portability issue on linux32 due to casting a c_void_ptr to a 64-bit integer. I've rewritten the test to avoid the cast, which I believe should resolve the issue (but in the interest of time am relying on the nightly testing to run on linux32 rather than doing it myself; it passes on linux64 and seems like it should resolve the lines of code in question). --- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
bradcray
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not think to run memleaks testing on these tests, and hadn't
realized that they hadn't freed their unmanaged classes. Do so here.
There was a portability issue on linux32 due to casting a c_void_ptr
to a 64-bit integer. I've rewritten the test to avoid the cast, which
I believe should resolve the issue, and via inspection of the generated
code it seems to. That said, due to a lack of time today, I haven't
had the chance to run the test on linux32, so am relying on the nightly
run to do that where, if I haven't fixed it, there shouldn't be any new
noise.