Fix build_configs after CHPL_TARGET_COMPILER=llvm change #17887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes adjustments to
build_configs
to work with the changesfrom PR #17800. In particular, that PR changed
make
for LLVMconfigurations to no longer build the runtime twice (once for LLVM and
once for the current C compiler). But the
build_configs
module buildwas relying on this behavior.
CHPL_TARGET_COMPILER
always in thebuild_configs
setenv scriptsCHPL_TARGET_COMPILER
separatelyNote that setting
CHPL_TARGET_COMPILER
on a PrgEnv system used toresult in an error but no longer does. I do not know when that changed
but it was at least not an error at the time of the last release (or at
least not an error to run printchplenv). Now it is necessary to set it in
order to request the C backend on such systems when the LLVM backend is
available.
Reviewed by @gbtitus and @Maxrimus - thanks!