Add newline between compile commands of the generated code #18694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds newline between the compilation commands of the generated code.
Context: CHAMPS team tried to use
--incremental
to reduce the backend's memoryfootprint. But they got errors from
exec
command because we were simplyrunning a huge one-liner to compile the generated code. Note that the
compilation of individual files were still separated, but only with
;
. So itwas still a single huge argument for execvp.
I am not fond of the solution but we couldn't think of any other quick alternative.
Test