Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline between compile commands of the generated code #18694

Merged
merged 2 commits into from Nov 10, 2021

Conversation

e-kayrakli
Copy link
Contributor

@e-kayrakli e-kayrakli commented Nov 6, 2021

This PR adds newline between the compilation commands of the generated code.

Context: CHAMPS team tried to use --incremental to reduce the backend's memory
footprint. But they got errors from exec command because we were simply
running a huge one-liner to compile the generated code. Note that the
compilation of individual files were still separated, but only with ;. So it
was still a single huge argument for execvp.

I am not fond of the solution but we couldn't think of any other quick alternative.

Test

  • linux64 --incremental in examples
  • linux64 --no-local --incremental in examples
  • linux64

Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
@e-kayrakli e-kayrakli marked this pull request as ready for review November 9, 2021 23:26
@e-kayrakli
Copy link
Contributor Author

I confirmed that this branch enables CHAMPS to compile with --incremental. I'll run some paratests.

@e-kayrakli e-kayrakli merged commit 978e761 into chapel-lang:main Nov 10, 2021
@e-kayrakli e-kayrakli deleted the incremental-makefile branch November 10, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants